2027a/murmur
Watch
6
1
Fork
You've already forked murmur
 0
Code Issues 15 Pull requests Projects Releases Packages Wiki Activity

[P1][osd] Remplacer le parsing stdin par un framing JSONL borné et résynchronisable #29

New issue
Closed
opened 2026-07-31 21:05:14 +00:00 by mathieu · 2 comments
mathieu commented 2026-07-31 21:05:14 +00:00
Owner
Copy link

Constat

Le helper lit 16 Kio puis termine immédiatement sur HUP, même si davantage est disponible (helpers/osd-gtk/murmur-osd.py:169-202). Le dépassement 64 Kio efface tout le buffer et certaines exceptions JSON (ValueError, RecursionError) sortent du callback. Les booléens passent aussi pour des entiers.

Tâche

Implémenter un petit automate de framing: drainer avec budget jusqu'à EAGAIN, traiter les lignes avant HUP, jeter une frame trop longue jusqu'au LF, attraper les erreurs de ressources et valider strictement types/ranges.

Critères d'acceptation

  • Un terminal après 16 Kio est traité malgré HUP.
  • Une frame géante ne corrompt pas la suivante.
  • JSON profond/grand/mal typé ne tue pas le helper.
  • Une frame valide suivante reste traitée.

Validation

python3 -m unittest helpers/osd-gtk/test_murmur_osd.py

## Constat Le helper lit 16 Kio puis termine immédiatement sur HUP, même si davantage est disponible (`helpers/osd-gtk/murmur-osd.py:169-202`). Le dépassement 64 Kio efface tout le buffer et certaines exceptions JSON (`ValueError`, `RecursionError`) sortent du callback. Les booléens passent aussi pour des entiers. ## Tâche Implémenter un petit automate de framing: drainer avec budget jusqu'à EAGAIN, traiter les lignes avant HUP, jeter une frame trop longue jusqu'au LF, attraper les erreurs de ressources et valider strictement types/ranges. ## Critères d'acceptation - Un terminal après 16 Kio est traité malgré HUP. - Une frame géante ne corrompt pas la suivante. - JSON profond/grand/mal typé ne tue pas le helper. - Une frame valide suivante reste traitée. ## Validation `python3 -m unittest helpers/osd-gtk/test_murmur_osd.py`
hermes commented 2026-08-07 17:29:14 +00:00
Member
Copy link

Correctif proposé dans la PR #42 (mathieu/murmur#42). Les validations ciblées sous race sont détaillées dans la PR.

Correctif proposé dans la PR #42 (https://git.2027a.net/mathieu/murmur/pulls/42). Les validations ciblées sous race sont détaillées dans la PR.
hermes commented 2026-08-07 18:02:38 +00:00
Member
Copy link

Correctif proposé et validé dans la PR #42 : mathieu/murmur#42.

Correctif proposé et validé dans la PR #42 : https://git.2027a.net/mathieu/murmur/pulls/42.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/application-paste-rules
feat/hyprland-paste
release
chore/remove-forgejo-ci
fix/trusted-literal-lan-preflight-61
fix/nonblocking-log-open-60
fix/journal-validation-before-mutation-59
fix/installcheck-fail-fast-58
fix/quote-spacing-57
fix/live-stop-audio-cleanup-56
chore/migrate-2027a
fix/stt-fatal-priority-49
fix/config-policy
verify/compatible-prs
fix/wav-portable-memfd
fix/ipc-subscribe-decoder
v0.1.0-rc1
Labels
Clear labels   
Agent/Autonomous OK
Safe for an agent to proceed autonomously within repo and risk rules.

  
Agent/Demeter
Demeter can or should work on this.

  
Agent/Hermes
Hermes can or should work on this.

  
Agent/Human
Requires a human decision, credential, review, or action.

  
Agent/Needs Review
Agent output requires review before merge, deploy, or operational action.

  
Area/API
API, backend interface, routes, schemas, or contracts.

  
Area/Auth
Authentication, authorization, identity, permissions, or sessions.

  
Area/CLI
Command-line interface, flags, output formats, or shell workflows.

  
Area/Data
Database, persistence, migrations, data model, import, or export.

  
Area/Docs
Documentation area, docs site, or content structure.

  
Area/Infra
Infrastructure, hosting, networking, system config, or platform operations.

  
Area/UI
Frontend or user interface.

  
CI/Failing
CI currently fails or this work addresses a CI failure.

  
CI/Flaky
Intermittent test or pipeline failure.

  
CI/Green
CI is known passing or validation is complete.

  
CI/Needs Runner
Requires runner setup, capacity, labels, or permissions.

  
CI/Needs Workflow
Requires a CI workflow or pipeline definition.

  
Compat/Backward Compatible
Explicitly backward-compatible change.

  
Compat/Breaking
Breaking change that will not be backward compatible.

  
Compat/Migration
Requires data, config, API, user, or operator migration.

  
Deploy/Ansible
Related to an Ansible-managed deployment path.

  
Deploy/Blocked
Deployment is blocked.

  
Deploy/Homelab
Related to local or homelab deployment.

  
Deploy/Needs Config
Needs configuration, environment variables, service definitions, or operator settings.

  
Deploy/Needs Secret
Needs secret, token, key, credential, or protected variable provisioning.

  
Deploy/Ready
Ready to deploy.

  
Deploy/Rollback
Rollback needed, rollback path involved, or rollback plan required.

  
Kind/Bug
Something is not working. Use for confirmed or suspected defects.

  
Kind/Chore
Maintenance, dependency bumps, cleanup, repository or tool configuration.

  
Kind/Design
Product, UX, API, architecture, or workflow design before implementation.

  
Kind/Documentation
Documentation changes or missing documentation.

  
Kind/Enhancement
Improve existing functionality without changing its core purpose.

  
Kind/Feature
New functionality. Use for net-new product or technical capabilities.

  
Kind/Refactor
Internal restructuring without intended behavior change.

  
Kind/Security
Security issue or security-sensitive change.

  
Kind/Spike
Exploration or prototype intended to reduce uncertainty.

  
Kind/Testing
Tests, QA, validation, fixtures, or coverage work.

  
Ops/Backup
Backup or restore.

  
Ops/Incident
Incident response, outage, emergency fix, or postmortem.

  
Ops/Maintenance
Routine maintenance, housekeeping, or operational cleanup.

  
Ops/Monitoring
Monitoring, alerts, metrics, logs, or observability.

  
Ops/Upgrade
Version upgrade, migration between versions, or upgrade planning.

  
Priority
Critical
 Production-breaking, security-critical, urgent, or otherwise must be addressed immediately.

  
Priority
High
 Important and should be handled soon.

  
Priority
Low
 Low urgency, nice-to-have, or can wait.

  
Priority
Medium
 Normal priority.

  
Priority
Someday
 Worth keeping but not scheduled.

  
Reviewed
Confirmed
 Issue has been confirmed during triage.

  
Reviewed
Duplicate
 This issue or pull request already exists elsewhere.

  
Reviewed
Invalid
 Not valid, not reproducible, or not actionable as filed.

  
Reviewed
Won't Fix
 Deliberately not planned.

  
Risk
Critical
 Very sensitive; requires explicit human approval before action.

  
Risk
High
 Could break production, data, security, compatibility, or important workflows.

  
Risk
Low
 Low operational, data, security, or compatibility risk.

  
Risk
Medium
 Some risk; needs care and appropriate verification.

  
Security/Auth
Authentication or authorization behavior.

  
Security/Disclosure
Sensitive vulnerability or disclosure process.

  
Security/Hardening
Security improvement or hardening.

  
Security/Secret
Secrets, tokens, keys, credentials, or secret handling involved.

  
Size
L
 Large task.

  
Size
M
 Medium task.

  
Size
S
 Small task.

  
Size
XL
 Needs decomposition before implementation.

  
Size
XS
 Tiny change, likely under 30 minutes.

  
Stack/Ansible
Ansible playbooks, roles, inventories, collections, or variables.

  
Stack/Docker
Docker, Compose, images, containers, or registries.

  
Stack/Forgejo
Forgejo/Gitea repositories, API, permissions, webhooks, runners, or settings.

  
Stack/Hermes
Hermes Agent, profiles, gateway, tools, skills, cron jobs, or configuration.

  
Stack/Node
Node.js, npm, frontend tooling, or JavaScript runtime.

  
Stack/Postgres
PostgreSQL database, SQL, indexes, migrations, backups, or tuning.

  
Stack/Python
Python code, packaging, tooling, or runtime.

  
Stack/Systemd
systemd services, timers, units, journals, or service lifecycle.

  
Status
Abandoned
 Work was started but intentionally abandoned or left stale.

  
Status
Blocked
 Something external blocks progress.

  
Status
In Progress
 Work has started.

  
Status
In Review
 Waiting for human, peer, code, or deployment review.

  
Status
Need More Info
 Feedback, reproduction details, acceptance criteria, or a decision is required.

  
Status
Ready
 Ready to be picked up by a human or agent.

No labels
Agent/Autonomous OK
Agent/Demeter
Agent/Hermes
Agent/Human
Agent/Needs Review
Area/API
Area/Auth
Area/CLI
Area/Data
Area/Docs
Area/Infra
Area/UI
CI/Failing
CI/Flaky
CI/Green
CI/Needs Runner
CI/Needs Workflow
Compat/Backward Compatible
Compat/Breaking
Compat/Migration
Deploy/Ansible
Deploy/Blocked
Deploy/Homelab
Deploy/Needs Config
Deploy/Needs Secret
Deploy/Ready
Deploy/Rollback
Kind/Bug
Kind/Chore
Kind/Design
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Refactor
Kind/Security
Kind/Spike
Kind/Testing
Ops/Backup
Ops/Incident
Ops/Maintenance
Ops/Monitoring
Ops/Upgrade
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Priority
Someday
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Risk
Critical
Risk
High
Risk
Low
Risk
Medium
Security/Auth
Security/Disclosure
Security/Hardening
Security/Secret
Size
L
Size
M
Size
S
Size
XL
Size
XS
Stack/Ansible
Stack/Docker
Stack/Forgejo
Stack/Hermes
Stack/Node
Stack/Postgres
Stack/Python
Stack/Systemd
Status
Abandoned
Status
Blocked
Status
In Progress
Status
In Review
Status
Need More Info
Status
Ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
2027a/murmur#29
No description provided.